Fixing global add in linux root folder #1029 #1344
Conversation
|
Getting error fetching modules |
|
@Daniel15, assigning to you |
|
Please merge this asap, since I'm trying to use yarn to install pm2 globally :) |
| const path = require('path'); | ||
| let userHome = require('user-home'); | ||
| if (process.platform === 'linux' && process.env.USER === 'root') { | ||
| userHome = path.resolve(process.execPath, '..', '..', 'lib'); |
There was a problem hiding this comment.
This makes an assumption about where Node.js is installed, which could vary based on the environment (eg. /usr/bin/node if the user installed it via a package manager, /usr/local/bin/node or /opt/nodejs/ or really anything else if they compiled it themselves or used something like nvm).
If you want to use /usr/local/lib/ then it's probably best to just hard-code that here. Don't use /usr/lib as that's purely for libraries managed by the system.
I think /usr/local/share/ is actually the right place for global Node.js modules as they're not native code and are thus platform-independent. Either /usr/local/share or /usr/local/lib is fine though.
There was a problem hiding this comment.
Just to understand...
When you say that I made an assumption (e.g. /usr/bin/node) you're talking about this variable process.execPath which contains the path to node bin, right?
So, if I have a custom node location, it will contain another path and this path.resolve(process.execPath, '..', '..', 'lib'); creates a bug.
That's it?
There was a problem hiding this comment.
Yes :) What I mean is that for example, what if Node.js is installed at /opt/node/versions/6.91/? Then ../../lib will resolve to /opt/node/lib which is probably not what you want.
| const path = require('path'); | ||
| let userHome = require('user-home'); | ||
| if (process.platform === 'linux' && process.env.USER === 'root') { | ||
| userHome = path.resolve(process.execPath, '..', '..', 'lib'); |
There was a problem hiding this comment.
Just to understand...
When you say that I made an assumption (e.g. /usr/bin/node) you're talking about this variable process.execPath which contains the path to node bin, right?
So, if I have a custom node location, it will contain another path and this path.resolve(process.execPath, '..', '..', 'lib'); creates a bug.
That's it?
|
Cool, let's try this out and see how it goes! |
Summary
Fixing
yarn global addbeing installed in root folder described in issue #1029.
Users can't access
/root/.yarn-*.Using
/usr/local/libinstead like npm modules (/usr/local/lib/node_modules)eg:
Reference