Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoids using Array.prototype.includes since it is not avaialble in no… #3139

Merged

Conversation

MiguelMadero
Copy link
Contributor

Fixes #3138

@MiguelMadero
Copy link
Contributor Author

The test failures seem unrelated to my changes. I checked out master and it fails locally as well :(
Are these tests flaky? This is the first time for me running it and sending a PR. Can someone help me decipher the issue here? I manually tested this version with node 6 and global installs still work fine.

@arcanis
Copy link
Member

arcanis commented Apr 20, 2017

Thanks! I think those tests are flaky, yes. We're working on it :(

@Turbo87
Copy link

Turbo87 commented Apr 20, 2017

@arcanis do you think it would be possible to do a quick bugfix release including this fix? right now all Node 4 builds on Travis CI that use yarn are broken because Travis will try to install the most recent version.

@MiguelMadero MiguelMadero deleted the mmadero/fixes-use-of-array-includes branch April 20, 2017 20:33
@MiguelMadero
Copy link
Contributor Author

@Turbo87 while I think it's important to have the latest yarn and I would also like a release with this changes, the following installation step is working for us to pin yarn to 0.22.0

  - curl -o- -L https://yarnpkg.com/install.sh | bash -s -- --version 0.22.0

@Turbo87
Copy link

Turbo87 commented Apr 21, 2017

@MiguelMadero I know, but then you'd have to explicitly add the yarn installation instructions to your TravisCI config, but Travis already automatically detects the existance of a yarn.lock file and will install and use yarn then unless you overwrite those instructions. I'd personally rather keep using the defaults instead of having to touch the config in every one of my projects.

@MiguelMadero
Copy link
Contributor Author

MiguelMadero commented Apr 22, 2017 via email

arcanis pushed a commit to arcanis/yarn that referenced this pull request Apr 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants