Adds compatibility for cordovaDependencies engine

[bytenik]

See https://cordova.apache.org/docs/en/latest/guide/hybrid/plugins/#specifying-cordova-dependencies for a description of when the cordovaDependencies engine is used.

Without this change, freshly installed Cordova plugins generate errors on yarn add. This was mentioned in #3437 a while back but no one ever made a pull request to resolve it.

[BYK]

Hi, thanks for the PR!

Can you run yarn prettier and update the PR with those changes?

[BYK]

@bestander @arcanis may be we should extend this ignore list via an environment variable so we don't have to keep this manual list in the code?

[arcanis]

I'm fine with the manual list in this particular case (I fear allowing to configure this field would trigger non-obvious issues where a package would work on some computers but not others because an ignore key hasn't been set), but if we are to make this configurable, it should probably be through the use of the yarnrc rather than an environment variable.

[BYK]

but if we are to make this configurable, it should probably be through the use of the yarnrc rather than an environment variable.

Great idea, yeah.

[bytenik]

Prettier doesn't seem to do anything.

yarn prettier v0.27.5
$ node scripts/prettier.js write
Done in 7.03s.

C:\Users\bytenik\AppData\Local\Temp\yarn>git status
On branch patch-1
Your branch is up-to-date with 'origin/patch-1'.
nothing to commit, working tree clean

C:\Users\bytenik\AppData\Local\Temp\yarn>

[BYK]

@bytenik oh interesting. Then would you mind rebasing onto master or merging from it to see if it would clear the CI failures?

[anpage]

The linter is failing because the line is too long. The comment needs to be shortened, which could be why yarn prettier couldn't automatically fix it.

[BYK]

@bytenik you may also us a link shortener like bit.ly

[bytenik]

I took the bit.ly approach.