Add ability to upgrade based on pattern #4610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philquinn
force-pushed
the
add-filtering-for-upgrade
branch
from
fee1735
to
dcaabe4
Compare
|
This change will decrease the build size from 9.83 MB to 9.83 MB, a decrease of 1.35 KB (0%)
|
arcanis
reviewed
Oct 3, 2017
src/package-request.js
Outdated
| depReqPatterns = depReqPatterns.filter( | ||
| dep => | ||
| filterByNames.indexOf(normalizePattern(dep.pattern).name) >= 0 || | ||
| (flags && flags.pattern && normalizePattern(dep.pattern).name.includes(flags.pattern)), |
There was a problem hiding this comment.
Shouldn't you use micromatch rather than includes, which will only search for the substring?
There was a problem hiding this comment.
Yeah you're right. Changed now.
philquinn
force-pushed
the
add-filtering-for-upgrade
branch
from
dcaabe4
to
2c4f016
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In PR #4571, upgrade was highlighted to be a candidate for adding a pattern option to allow filtering.
This can be used with the current args or by itself.
Usage:
yarn upgrade --pattern mypatternyarn upgrade diff-package --pattern mypatternTest plan
Added test that filter with pattern and with the current args together.