fix(request-manager): Flaky network messsage should be info, not warning #4621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary** Sometimes Yarn saturates the network and sometimes the network itself has issues, especially on CI and Yarn reports this as a warning. This should be a simple info message unless it actually completely fails. This also fixes a flaky integration test with react-scripts. **Test plan** `react-scripts` integration test should not be flaky anymore.
|
This change will decrease the build size from 9.9 MB to 9.9 MB, a decrease of 347 bytes (0%)
|
joaolucasl
pushed a commit
to joaolucasl/yarn
that referenced
this pull request
Oct 27, 2017
…ing (yarnpkg#4621) **Summary** Sometimes Yarn saturates the network and sometimes the network itself has issues, especially on CI and Yarn reports this as a warning. This should be a simple info message unless it actually completely fails. This also fixes a flaky integration test with react-scripts. **Test plan** `react-scripts` integration test should not be flaky anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sometimes Yarn saturates the network and sometimes the network itself
has issues, especially on CI and Yarn reports this as a warning. This
should be a simple info message unless it actually completely fails.
This also fixes a flaky integration test with react-scripts.
Test plan
react-scriptsintegration test should not be flaky anymore.