Make sure TarballFetcher error messages contain names of problematic files #5964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't required to open the file (`fd` is used), but it allows the stream to have a useful `path` attribute.
sth
changed the title
sth
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The error messages caused by TarballFetcher are supposed to contain the name of the offending file. The name is taken from the streams
pathattribute, but since a recent change this attribute is empty.This PR populates the attribute again and tests that the path is actually mentioned in the TarballFetcher error messages.
Test plan
Existing tests have been modified to be stricter than before and test for this problem.