Fixes the bundle build #6274
Fixes the bundle build #6274
Conversation
|
yarn.lock
Outdated
| @@ -5,14 +5,12 @@ | |||
| "@babel/code-frame@^7.0.0-beta.35": | |||
| version "7.0.0-beta.55" | |||
| resolved "https://registry.yarnpkg.com/@babel/code-frame/-/code-frame-7.0.0-beta.55.tgz#71f530e7b010af5eb7a7df7752f78921dd57e9ee" | |||
| integrity sha1-cfUw57AQr163p993UveJId1X6e4= | |||
There was a problem hiding this comment.
Was this intended? It looks like all of the integrity hashes have been removed.
There was a problem hiding this comment.
Nope, not intended, my machine wasn't using the nightly yet 😞
|
FWIW, I tried installing the |
| @@ -34,6 +34,10 @@ const compiler = webpack({ | |||
| exclude: /node_modules/, | |||
| loader: 'babel-loader', | |||
| }, | |||
| { | |||
| test: /rx\.lite\.aggregates\.js/, | |||
| use: 'imports-loader?define=>false' | |||
There was a problem hiding this comment.
Is it valid to have a use entry here? It seems to work for me too, but... module.loaders is apparently an alias for module.use. module.use entries must have a loader field (as the babel-loader entry above does). The syntax you're using here is assumed to be in a module.rules entry, which is how Webpack wants us to configure loaders since v2. Yet this seems to work anyway...
We should probably update webpack :/ It's difficult to even find documentation for this version.
|
I have installed the .deb from this CircleCI build too, but I still get the same error: [1/4] Resolving packages... I will be happy if any one could describe a workaround! Thank you. |
Summary
#6208 caused some rx packages to be upgraded, which in turn broke the bundling process (the new release doesn't play well with webpack because of its amd definition). This diff updates the configuration to hack around this issue.
Test plan