Comprehensive reorganization of localization file #6521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The review will be fun, but this is a really good idea thanks for tackling this! I love "better engineering" PRs like this one 🙂 |
arcanis
reviewed
Oct 15, 2018
| @@ -210,7 +210,7 @@ export default class Git implements GitRefResolvingInterface { | |||
| if (await Git.repoExists(secureRef)) { | |||
| return secureRef; | |||
| } else { | |||
| reporter.warn(reporter.lang('downloadHTTPWithoutCommit', ref.repository)); | |||
| reporter.warn(reporter.lang('getDownloadHttpWithoutCommit', ref.repository)); | |||
There was a problem hiding this comment.
Shouldn't this be gitDownloadHttpWithoutCommit (rather than get)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I was doing some work on a feature and a saw how unorganized the localization file was. Not only does it make it a crap shoot for where to put a new string (if you even feel like doing it), it also makes it really difficult to approach translating into a new language at all. To that end, I made my best effort to organize the strings. I have grouped them by command (using common and core for things that don't relate to a specific command) alphabetized the groups, and alphabetized the strings within the groups. I also added a header to explain the organization within the file.
This will make the file much cleaner and more maintainable. It also makes it easy to catch people not adding strings in the right place during code review.
I do understand this will be a pain for a little bit because it will cause a number of merge conflicts. I feel that the organization and maintenance gains will make it worth it, though.
Test plan
If the tests pass, this should be good. I am not intentionally changing any functionality.