Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove commander's allowUnknownOption method call #777

Merged
merged 1 commit into from Oct 12, 2016
Merged

Remove commander's allowUnknownOption method call #777

merged 1 commit into from Oct 12, 2016

Conversation

wyze
Copy link
Member

@wyze wyze commented Oct 12, 2016

Summary

This solves #693 by removing the .allowUnknownOption() call on commander.

Test plan

Before
❯ yarn --vesrion
yarn install v0.15.1
success Already up-to-date.
✨  Done in 0.16s.
After
❯ yarn --vesrion
  error: unknown option `--vesrion'

@sebmck sebmck merged commit e5a7cc1 into yarnpkg:master Oct 12, 2016
@sebmck
Copy link
Contributor

sebmck commented Oct 12, 2016

Didn't even know we had this line... Thanks for the PR!

This was referenced Oct 12, 2016
Closed
Closed
@wyze wyze mentioned this pull request Oct 13, 2016
Closed
@Zajn Zajn mentioned this pull request Oct 19, 2016
Closed
@hawkrives hawkrives mentioned this pull request Oct 20, 2016
Closed
@merriam merriam mentioned this pull request Mar 17, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sebmck sebmck

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wyze @sebmck