yarpc.Config: Option to disable observability middleware #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinav
changed the title
Codecov Report
@@ Coverage Diff @@
## _start_-disableMetrics-part_1.0 #1421 +/- ##
===================================================================
- Coverage 90.69% 90.45% -0.25%
===================================================================
Files 209 209
Lines 10344 10249 -95
===================================================================
- Hits 9382 9271 -111
- Misses 638 645 +7
- Partials 324 333 +9
Continue to review full report at Codecov.
|
peats-bond
approved these changes
Jan 30, 2018
|
|
||
| // DisableAutoObservabilityMiddleware is used to stop the dispatcher from | ||
| // automatically attaching observability middleware to all inbounds and | ||
| // outbounds. It is the assumption that if if this option is disabled the |
| // outbounds. It is the assumption that if if this option is disabled the | ||
| // observability middleware is being inserted in the Inbound/Outbound | ||
| // Middleware. | ||
| DisableAutoObservabilityMiddleware bool |
There was a problem hiding this comment.
Can we drop Auto? I think it's a bit verbose
There was a problem hiding this comment.
Could get away with ExcludeObservabilityMiddleware
kriskowal
approved these changes
Feb 6, 2018
| // outbounds. It is the assumption that if if this option is disabled the | ||
| // observability middleware is being inserted in the Inbound/Outbound | ||
| // Middleware. | ||
| DisableAutoObservabilityMiddleware bool |
There was a problem hiding this comment.
Could get away with ExcludeObservabilityMiddleware
abhinav
approved these changes
Feb 6, 2018
willhug
force-pushed
the
disableMetrics-part_1.0
branch
from
e077c0e
to
a4bd8a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: In order to allow some users to customize how they attach
observability middleware (e.g. users that want to log stats with shard
key). This PR adds the ability to not add the built in observability
middleware on the dispatcher. By default it's currently always added.
This will allow users to input their own middleware for observability
explicitly. Since it would be a breaking change to remove it silently,
this needs to be an new option that explicitly disables the middleware..