New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transports: merge common error handling. #322
Conversation
@bombela, thanks for your PR! By analyzing the annotation information on this pull request, we identified @abhinav, @kriskowal and @breerly to be potential reviewers |
err = errors.HandlerTimeoutError(treq.Caller, treq.Service, | ||
treq.Procedure, deadline.Sub(start)) | ||
} | ||
err = transport.SafelyCallHandler(h.Handler, start, ctx, httpOptions, treq, newResponseWriter(w)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use err :=
here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
github review feature <3
7376a0f
to
10856a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* master: (31 commits) Prepare v0.2.0 (#339) crossdock: Add an apachethrift crossdock behavior (#335) Use thriftrw-go >= 0.2, < 0.3 (#336) Thread sk, rk, and rd through reqmeta to transports (#324) version-check: Fix for OSX (#334) thrift/outbound: Support TMultiplexedProtocol (#333) transports: merge common error handling. (#322) Adding version.go (#331) Fix go docs link travis: Split crossdock and linter out (#323) Catch (recover) panics from user handlers. (#315) thrift: Suggest plugins over --yarpc (#320) Support open tracing in HTTP and TChannel (#307) thrift: Implement ThriftRW plugin (#317) Reformat changelog (#316) Rename some behaviors with more obvious names. (#311) Changelog for v0.1.1 Go back to regular github.com/yarpc/yarpc-go import path (#305) changelog (#303) deps - Pin to thriftrw ~0.1 (#301) ...
First try at it, before reducing the number of function hops in both
transports.