WIP Thread sk, rk, and rd through reqmeta to transports #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kriskowal, thanks for your PR! By analyzing the annotation information on this pull request, we identified @abhinav, @breerly and @bombela to be potential reviewers |
kriskowal
changed the title
|
Blocking on integration for the routing key property in tchannel-go. |
HelloGrayson
approved these changes
Sep 15, 2016
| @@ -17,7 +17,7 @@ import: | |||
| subpackages: | |||
| - gomock | |||
| - package: github.com/uber/tchannel-go | |||
| version: ^1.1.0 | |||
| version: ^1.2.0 | |||
There was a problem hiding this comment.
This can be just ^1.2, no reason to specify the patch.
kriskowal
added a commit
that referenced
this pull request
Sep 16, 2016
* Context is no longer a reqmeta property * Thread shard key, routing key, and routing delegate * Uprev tchannel
abhinav
reviewed
Sep 16, 2016
|
|
||
| GetProcedure() string | ||
| GetHeaders() Headers | ||
| GetShardKey() string | ||
| GetRoutingKey() string | ||
| GetRoutingDelegate() string |
There was a problem hiding this comment.
Do servers have no need of accessing this information?
willhug
pushed a commit
that referenced
this pull request
Sep 19, 2016
* master: (31 commits) Prepare v0.2.0 (#339) crossdock: Add an apachethrift crossdock behavior (#335) Use thriftrw-go >= 0.2, < 0.3 (#336) Thread sk, rk, and rd through reqmeta to transports (#324) version-check: Fix for OSX (#334) thrift/outbound: Support TMultiplexedProtocol (#333) transports: merge common error handling. (#322) Adding version.go (#331) Fix go docs link travis: Split crossdock and linter out (#323) Catch (recover) panics from user handlers. (#315) thrift: Suggest plugins over --yarpc (#320) Support open tracing in HTTP and TChannel (#307) thrift: Implement ThriftRW plugin (#317) Reformat changelog (#316) Rename some behaviors with more obvious names. (#311) Changelog for v0.1.1 Go back to regular github.com/yarpc/yarpc-go import path (#305) changelog (#303) deps - Pin to thriftrw ~0.1 (#301) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for three RPC request properties: shard key, routing key, and routing delegate, writing them to the wire in the way appropriate per transport.
r @prashantv @breerly