HTTP transport constructors refactor #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kriskowal, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bombela, @abhinav and @AlexAPB to be potential reviewers. |
kriskowal
force-pushed
the
http-transport-refactor
branch
2 times, most recently
from
f37a7f3
to
170e5ec
Compare
kriskowal
force-pushed
the
transport-lifecycle
branch
from
a17af61
to
f3bacc5
Compare
kriskowal
force-pushed
the
http-transport-refactor
branch
from
170e5ec
to
fec4831
Compare
kriskowal
added a commit
that referenced
this pull request
Dec 7, 2016
kriskowal
force-pushed
the
http-transport-refactor
branch
from
fec4831
to
1d8bf3a
Compare
kriskowal
added a commit
that referenced
this pull request
Dec 7, 2016
Merged
willhug
approved these changes
Dec 7, 2016
| @@ -26,12 +26,15 @@ import ( | |||
| "sync" | |||
| "time" | |||
|
|
|||
| "github.com/opentracing/opentracing-go" | |||
kriskowal
force-pushed
the
transport-lifecycle
branch
from
f3bacc5
to
8c5f949
Compare
kriskowal
force-pushed
the
http-transport-refactor
branch
from
1d8bf3a
to
c9aec00
Compare
kriskowal
added a commit
that referenced
this pull request
Dec 7, 2016
kriskowal
force-pushed
the
http-transport-refactor
branch
from
c9aec00
to
b07d4a7
Compare
kriskowal
added a commit
that referenced
this pull request
Dec 7, 2016
kriskowal
force-pushed
the
http-transport-refactor
branch
from
b07d4a7
to
1d5b97d
Compare
kriskowal
added a commit
that referenced
this pull request
Dec 7, 2016
kriskowal
force-pushed
the
http-transport-refactor
branch
from
1d5b97d
to
95f6fb0
Compare
HelloGrayson
approved these changes
Dec 7, 2016
| @@ -123,19 +121,17 @@ func runTChannelClient(b *testing.B, c *tchannel.Channel, hostPort string) { | |||
| } | |||
|
|
|||
| func Benchmark_HTTP_YARPCToYARPC(b *testing.B) { | |||
| httpTransport := yhttp.NewTransport() | |||
| Unary: yhttp.NewOutbound( | ||
| single.New(hostport.PeerIdentifier("http://localhost:8999"), httpTransport), | ||
| ), | ||
| Unary: httpTransport.NewSingleOutbound("http://localhost:8999"), |
There was a problem hiding this comment.
Holy hell this is so much cleaner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes, based on #529, pivot the HTTP transport away from using New* functions on the "transport/http" package to using http.NewTransport() and transport.New* methods for all construction needs. This includes the introduction of transport.NewSingleOutbound, which restores simplicity to the simple case. In all of these cases, the tracer gets threaded from the transport’s configuration into the creation of all dependent inbounds and outbounds. NewSingleOutbound benefits from being able to thread the transport into the single peer chooser behind the scenes.