Remove with registry #542
Merged
Remove with registry #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kriskowal, thanks for your PR! By analyzing the history of the files in this pull request, we identified @abhinav, @jcorbin and @breerly to be potential reviewers. |
kriskowal
added a commit
that referenced
this pull request
Dec 7, 2016
kriskowal
force-pushed
the
http-transport-refactor
branch
from
1d8bf3a
to
c9aec00
Compare
kriskowal
force-pushed
the
remove-with-registry
branch
from
2943e4c
to
4ba832b
Compare
kriskowal
added a commit
that referenced
this pull request
Dec 7, 2016
kriskowal
force-pushed
the
http-transport-refactor
branch
from
c9aec00
to
b07d4a7
Compare
kriskowal
force-pushed
the
remove-with-registry
branch
from
4ba832b
to
a4acbac
Compare
kriskowal
added a commit
that referenced
this pull request
Dec 7, 2016
kriskowal
force-pushed
the
http-transport-refactor
branch
from
b07d4a7
to
1d5b97d
Compare
kriskowal
force-pushed
the
remove-with-registry
branch
from
a4acbac
to
19b3270
Compare
kriskowal
added a commit
that referenced
this pull request
Dec 7, 2016
kriskowal
force-pushed
the
http-transport-refactor
branch
from
1d5b97d
to
95f6fb0
Compare
kriskowal
force-pushed
the
remove-with-registry
branch
from
19b3270
to
dcb7fef
Compare
kriskowal
added a commit
that referenced
this pull request
Dec 7, 2016
kriskowal
force-pushed
the
remove-with-registry
branch
from
dcb7fef
to
0dc0017
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #540, just removes the WithRegistry method on inbounds, in favor of calling SetRegistry just like dispatcher, even in tests where the fluent API was convenient.