Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove with registry #542

Merged
merged 1 commit into from
Dec 7, 2016
Merged

Remove with registry #542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions transport/http/inbound.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,6 @@ func (i *Inbound) WithTracer(tracer opentracing.Tracer) *Inbound {
return i
}

// WithRegistry configures a registry to handle incoming requests,
// as a chained method for convenience.
func (i *Inbound) WithRegistry(registry transport.Registry) *Inbound {
i.registry = registry
return i
}

// SetRegistry configures a registry to handle incoming requests.
// This satisfies the transport.Inbound interface, and would be called
// by a dispatcher when it starts.
Expand Down
6 changes: 3 additions & 3 deletions transport/http/inbound_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,9 @@ func TestInboundStartAndStop(t *testing.T) {

func TestInboundStartError(t *testing.T) {
x := NewTransport()
err := x.NewInbound("invalid").
WithRegistry(new(transporttest.MockRegistry)).
Start()
i := x.NewInbound("invalid")
i.SetRegistry(new(transporttest.MockRegistry))
err := i.Start()
assert.Error(t, err, "expected failure")
}

Expand Down
7 changes: 0 additions & 7 deletions transport/tchannel/inbound.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,13 +65,6 @@ func (i *Inbound) WithTracer(tracer opentracing.Tracer) *Inbound {
return i
}

// WithRegistry configures a registry to handle incoming requests,
// as a chained method for convenience.
func (i *Inbound) WithRegistry(registry transport.Registry) *Inbound {
i.registry = registry
return i
}

// SetRegistry configures a registry to handle incoming requests.
// This satisfies the transport.Inbound interface, and would be called
// by a dispatcher when it starts.
Expand Down