TChannel Constructors Refactor #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kriskowal, thanks for your PR! By analyzing the history of the files in this pull request, we identified @abhinav, @breerly and @AlexAPB to be potential reviewers. |
kriskowal
force-pushed
the
remove-with-registry
branch
from
2943e4c
to
4ba832b
Compare
kriskowal
force-pushed
the
tchannel-transport-refactor
branch
from
c2a1e68
to
0eedc06
Compare
kriskowal
added a commit
that referenced
this pull request
Dec 7, 2016
kriskowal
force-pushed
the
remove-with-registry
branch
from
4ba832b
to
a4acbac
Compare
kriskowal
force-pushed
the
tchannel-transport-refactor
branch
from
0eedc06
to
8288865
Compare
kriskowal
added a commit
that referenced
this pull request
Dec 7, 2016
kriskowal
force-pushed
the
remove-with-registry
branch
from
a4acbac
to
19b3270
Compare
kriskowal
force-pushed
the
tchannel-transport-refactor
branch
from
8288865
to
2aaac8f
Compare
kriskowal
added a commit
that referenced
this pull request
Dec 7, 2016
kriskowal
force-pushed
the
remove-with-registry
branch
from
19b3270
to
dcb7fef
Compare
kriskowal
force-pushed
the
tchannel-transport-refactor
branch
from
2aaac8f
to
af0c6cf
Compare
kriskowal
added a commit
that referenced
this pull request
Dec 7, 2016
kriskowal
force-pushed
the
tchannel-transport-refactor
branch
from
af0c6cf
to
1a312e1
Compare
kriskowal
added a commit
that referenced
this pull request
Dec 7, 2016
kriskowal
force-pushed
the
remove-with-registry
branch
from
dcb7fef
to
0dc0017
Compare
kriskowal
force-pushed
the
tchannel-transport-refactor
branch
from
1a312e1
to
0ac4b3f
Compare
kriskowal
added a commit
that referenced
this pull request
Dec 7, 2016
willhug
suggested changes
Dec 8, 2016
| "go.uber.org/yarpc/transport" | ||
| ) | ||
|
|
||
| type inboundConfig struct { |
| @@ -1,96 +1,71 @@ | |||
| // Copyright (c) 2016 Uber Technologies, Inc. | |||
| package tchannel | ||
|
|
||
| import ( | ||
| "context" | ||
| "io" | ||
|
|
||
| "github.com/uber/tchannel-go" | ||
| "go.uber.org/atomic" |
| if config.name == "" { | ||
| err = fmt.Errorf("can't instantiate TChannelChannelTransport without channel or service name option") | ||
| } else { | ||
| ch, err = tchannel.NewChannel(config.name, &tchannel.ChannelOptions{ |
There was a problem hiding this comment.
since this is during initialization, should we just panic on errors?
| // | ||
| // All inbounds must have been assigned a registry to accept inbound requests. | ||
| func (t *ChannelTransport) Start() error { | ||
|
|
| return err | ||
| } | ||
|
|
||
| t.addr = t.ch.PeerInfo().HostPort |
There was a problem hiding this comment.
should we extract the t.addr grabbing into a function?
There was a problem hiding this comment.
Something to consider in a follow-up. This mechanically extracted from the old code.
| // channel to make requests to any connected peer. | ||
| func (t *ChannelTransport) NewOutbound() *ChannelOutbound { | ||
| return &ChannelOutbound{ | ||
| started: atomic.NewBool(false), |
There was a problem hiding this comment.
we don't need to set these every time, we can initialize started as a atomic.Bool and it will automatically be set to false.
There was a problem hiding this comment.
roger, changing to value instead of pointer, using the zero value.
|
|
||
| serverTChannel := ytchannel.NewChannelTransport( | ||
| ytchannel.WithServiceName("server"), | ||
| ) |
kriskowal
force-pushed
the
tchannel-transport-refactor
branch
from
0ac4b3f
to
d5d55ee
Compare
|
@willhug addressed, but keeping the panics out, just to be safe. |
willhug
approved these changes
Dec 8, 2016
HelloGrayson
approved these changes
Dec 8, 2016
HelloGrayson
reviewed
Dec 8, 2016
|
|
||
| tchannelTransport := tchannel.NewChannelTransport( | ||
| tchannel.WithListenAddr(":8082"), | ||
| tchannel.WithServiceName("yarpc-test"), |
There was a problem hiding this comment.
Is this something we can call for them? I don't love how they have to specify "yarpc-test".
This was referenced Dec 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #542, this change adds tchannel.NewChannelTransport as the new root object for constructing inbounds and outbounds using a wrapped TChannel, and removes the old Inbound/Outbound types.
The name and types deliberately leave open tchannel.NewTransport as a possibility post-1.0, which would not wrap a Channel and consequently be usable with transport.NewOutbound(chooser).