Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update webdriver-manager to latest version #299

Closed
yashaka opened this issue Mar 22, 2021 · 7 comments · Fixed by #318
Closed

update webdriver-manager to latest version #299

yashaka opened this issue Mar 22, 2021 · 7 comments · Fixed by #318

Comments

@yashaka
Copy link
Owner

yashaka commented Mar 22, 2021

current:
image
while:
image

@EmadDeve20
Copy link
Contributor

EmadDeve20 commented Mar 22, 2021

#301

@EmadDeve20
Copy link
Contributor

Hi @yashaka !
I'm trying to update this model with tips @aleksandr-kotlyar in the #301!

what is my wrong?
Screenshot from 2021-04-13 13-04-08

@aleksandr-kotlyar
Copy link
Collaborator

aleksandr-kotlyar commented Apr 13, 2021

Hi @yashaka !
I'm trying to update this model with tips @aleksandr-kotlyar in the #301!

what is my wrong?
Screenshot from 2021-04-13 13-04-08

Hi, @EmadDeve20!
Poetry sees version webdriver-manager==2.3.0 in pyproject.toml and tells you that there is nothing to update.
You should change webdriver-manager version in pyproject.toml before.

EmadDeve20 added a commit to EmadDeve20/selene that referenced this issue Apr 14, 2021
@EmadDeve20
Copy link
Contributor

#318

@aleksandr-kotlyar aleksandr-kotlyar linked a pull request Apr 15, 2021 that will close this issue
aleksandr-kotlyar added a commit that referenced this issue Apr 15, 2021
…atest_version

update webdriver-manager to latest version #299
github-actions bot added a commit that referenced this issue Apr 15, 2021
…atest_version

update webdriver-manager to latest version #299
@a-karro
Copy link

a-karro commented Apr 23, 2021

Just a comment: since selene has been moved to poetry, and poetry is super strict on versions, I would suggest to use ">=minimal version" pattern for better compatibility. Instead of "version": "==strict.version" I think it would be better to use ">=minimal.version". If selene relies on the latest and greatest: >=3.3.0, of course.
(at the moment I'm waiting for the next release of selene because pyshadow has listed their webdriver as >=2.5.3, and selene with its currently required 2.3.0 is no bueno)

@aleksandr-kotlyar
Copy link
Collaborator

Hi @a-karro! Thank you for your comment! I really appreciate it. But I want to correct your statements.
Not only poetry is super strict on versions, it can be requirements.txt or Pipfile, it is a conscious decision of developers to control versions on which they have tested their product and what they support for now.

Also you shouldn't wait for a new version of selene - you can use any dependency resolver which support few versions of sub-dependencies like poetry.

We will release new version of selene soon.

@aleksandr-kotlyar
Copy link
Collaborator

@a-karro selene 2.0.0a37 with webdriver-manager 3.3.0 has been released! 😉
Also selene 2.0.0a38 with webdriver-manager 3.4.1 has been released yesterday.
Thank you for using selene! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants