Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update webdriver-manager to latest version #299 #301

Closed
wants to merge 1 commit into from
Closed

update webdriver-manager to latest version #299 #301

wants to merge 1 commit into from

Conversation

EmadDeve20
Copy link
Contributor

@EmadDeve20 EmadDeve20 commented Mar 22, 2021

#299

so this is ok or now not?
I am a noob programmer and I'm here for learning. if I have a mistake please tell me!

@yashaka
Copy link
Owner

yashaka commented Mar 23, 2021

heh... so, it seems to be not like that simple, updating webdriver-manager broke the build somehow... Now we have to investiage deeper the reason...

@aleksandr-kotlyar
Copy link
Collaborator

aleksandr-kotlyar commented Mar 23, 2021

so this is ok or now not?

@EmadDeve20
Not yet.
But it's a good point to start from the beginning and investigate the issue step by step.
Here is a plan:

  1. Look at the CI - tests are failing.
  2. Go to details of the failed job. Look at the stacktrace.
  3. Try to google what happened and figure out what goes wrong and how to fix it.

Until all tests pass - this PR can't be merged.

@EmadDeve20
Copy link
Contributor Author

The code in the vim is correct and there is no problem in using pylint and YCM. I am confused. The selene model is also available, so why do we have an error in the test?

@aleksandr-kotlyar
Copy link
Collaborator

The code in the vim is correct and there is no problem in using pylint and YCM. I am confused. The selene model is also available, so why do we have an error in the test?

Before this PR tests passed. Then it's not a problem of previous PRs.

But on this PR tests are failing. So what has changed in this PR? The answer will be - dependencies.

@EmadDeve20 So you need to figure out why dependency update has caused such an error:

collecting ... collected 0 items / 1 error

==================================== ERRORS ====================================
________________________ ERROR collecting test session _________________________
/usr/lib/python3.8/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1014: in _gcd_import
    ???
<frozen importlib._bootstrap>:991: in _find_and_load
    ???
<frozen importlib._bootstrap>:975: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:671: in _load_unlocked
    ???
../../../.local/share/virtualenvs/selene-YGITccUt/lib/python3.8/site-packages/_pytest/assertion/rewrite.py:170: in exec_module
    exec(co, module.__dict__)
tests/acceptance/custom_browser/conftest.py:5: in <module>
    from selene import Config, Browser
E   ModuleNotFoundError: No module named 'selene'

@aleksandr-kotlyar
Copy link
Collaborator

@EmadDeve20 ! Good news! The problem was that Pipenv could not resolve dependencies after you have updated them. Thats why was an import error and test execution couldn't start.
This issue has been fixed in #302 by changing building instrument - we moved selene from Pipenv to Poetry. So, now you need to install poetry pip install poetry, and update webdriver_manager dependency in pyproject.toml file, and then do poetry lock to resolve and lock dependencies and poetry install to install them. Then make a new commit.

@EmadDeve20
Copy link
Contributor Author

I'm very sorry that I have a hardware problem and I think I can not fix it until a week ago. If you can solve it, solve it. Thanks and I'm very sorry, I really have a problem, I'm very sorry!

Thank you for all your help and training :D

@aleksandr-kotlyar
Copy link
Collaborator

I'm very sorry that I have a hardware problem and I think I can not fix it until a week ago. If you can solve it, solve it. Thanks and I'm very sorry, I really have a problem, I'm very sorry!

Thank you for all your help and training :D

Issue can wait for contributor for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants