Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] : Footer component #8

Merged
merged 7 commits into from
Jan 31, 2024

Conversation

linyers
Copy link
Contributor

@linyers linyers commented Jan 27, 2024

New feature for issue #7

Contain:

  • Footer component
  • Footer scss module designs
  • Github icon component
  • Github repository page link
  • yashchaudhari008 github profile link
  • Contributors page link

2024-01-27-104804_649x62_scrot

Copy link
Owner

@yashchaudhari008 yashchaudhari008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also current alignment looks little off:

Current Expected
image image

@yashchaudhari008 yashchaudhari008 changed the title add(feature): Footer component [FEATURE] : Footer component Jan 29, 2024
@yashchaudhari008
Copy link
Owner

yashchaudhari008 commented Jan 29, 2024

Thanks for contributing.

Please mention yourself on the issue, so that I can assign it to you

@linyers
Copy link
Contributor Author

linyers commented Jan 29, 2024

While making the changes, I encountered a bug with the font-weight of the Inter font. I was able to resolve it, but I'm unsure whether to include it in this pull request or create a new one.

@yashchaudhari008
Copy link
Owner

@linyers What's the exact issue?

@linyers
Copy link
Contributor Author

linyers commented Jan 30, 2024

The issue was with the Inter font. When attempting to increase the weight of the Inter font, it remained at the default (400). I also noticed that certain components were using a different weight than the default, and the weight stayed at 400 even when set to 800. So, I imported various weights for the Inter font, and the issue was resolved.

in src/index.scss
@import url("https://fonts.googleapis.com/css2?family=Inter:wght@400;500;600;700;800;900...");

@yashchaudhari008
Copy link
Owner

Can you check whether this happens only when Chrome is opened in incognito mode? Because this is happening in my case!

@yashchaudhari008
Copy link
Owner

Also, can you push your recent changes and request re-review?

@linyers
Copy link
Contributor Author

linyers commented Jan 31, 2024

Can you check whether this happens only when Chrome is opened in incognito mode? Because this is happening in my case!

I have been noticing that this seems to be some issue with browsers. I tested it on Chrome, Brave, and Firefox. I'm sharing some links that discuss this:

https://stackoverflow.com/questions/22001035/font-weight-ignored-in-chrome
tailwindlabs/tailwindcss#1402

I have tried different solutions, and the one that worked for me was importing the weights I am going to use:

@import url("http://fonts.googleapis.com/css?family=Open+Sans:400,300,500,800");

Copy link
Owner

@yashchaudhari008 yashchaudhari008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good! Thanks for contributing

@yashchaudhari008 yashchaudhari008 merged commit 8e6719c into yashchaudhari008:main Jan 31, 2024
@yashchaudhari008 yashchaudhari008 linked an issue Jan 31, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add link to github repo
2 participants