Dash 用の Docset 作成タスクを追加しました。 #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kminiatures おぉ、PR ありがとうございます! 手元で試してみましたが、一部の画像のPathが抜けているみたいですね 😓
もし英語の方でもうまく動くようでしたら、 rails/rails の方にも PR を投げておくとよいかもしれないですね 🌟 💭 @yui-knk パッと rails/rails を見た感じだと、まだ docrails 本体にも docset は導入されてなさそうに見えたのですが、docsetって既に導入されているor導入予定だったりしますか? |
|
上記の画像の部分以外は大丈夫そうでした! 🙆♀️ |
|
Markdown から生成しているのですが、出来あがった HTML を元にしたほうがみばえが良いので修正いたします... |
なるほど、ではこちらの PR は一旦マージしてしまって (docset 自体はうまく作成できているので 👌 🌟 )、上記の点は別途 Issue にあげちゃいますね 👍 |
This was referenced Aug 17, 2015
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
guides:generate:dashを追加しました。ディレクトリを指定しなければ
guides/output/dash/ja/ruby_on_rails_guides_local.ja.docsetができます。kindle.rb を参考にしました。おかしな箇所あればご指摘ください。