This repository has been archived by the owner on Feb 6, 2020. It is now read-only.
Test that network settings are applied (bsc#949193). #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvidner
force-pushed
the
keep_install_network_bsc949193
branch
from
ba57de8
to
ba01f89
Compare
mvidner
added a commit
to mvidner/yast-network
that referenced
this pull request
Nov 6, 2015
Conflicts: package/yast2-network.spec src/clients/lan_auto.rb NOTE that due to changes done in the development branch (master AKA SLE-12-SP1) in the meantime, the original bug bsc#949193 is not present, as evidenced by this new test: yast/autoyast-integration-test#42 It also seemed that a different bug (bsc#874259#c157) was present but my testing did not confirm that.
|
LGTM |
|
Thanks! Feel free to merge whenever you want. |
mvidner
added a commit
that referenced
this pull request
Nov 6, 2015
Test that network settings are applied (bsc#949193).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An integration test for yast/yast-network#347
This will not test SLE12-GA updates, which is where this bug actually occurred. The test harness needs to be extended to test that.