Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix setting default module section in installation control file #27

Merged
merged 2 commits into from
Jan 10, 2023

Conversation

mcalmer
Copy link
Contributor

@mcalmer mcalmer commented Sep 15, 2022

Problem

Default module selection using Full image does not work.

Solution

The template has already a section for default modules.
The XSL file just add a second section and YaST seems to take the "last" one specified which is the original from the template.

This PR modify/replace the existing section.

Testing

  • Tested manually

@mcalmer mcalmer force-pushed the fix-default-module-selection branch from c35b400 to 79b02e0 Compare January 10, 2023 09:36
@mcalmer mcalmer force-pushed the fix-default-module-selection branch from b9900bb to 73921e8 Compare January 10, 2023 11:30
@juliogonzalez
Copy link
Contributor

juliogonzalez commented Jan 10, 2023

Yast team: injecting the changelog entries in the middle is OK. Such changes are at IBS for months already, but this PR got lost here.

Copy link
Contributor

@teclator teclator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teclator teclator merged commit bbc0bb2 into master Jan 10, 2023
@teclator teclator deleted the fix-default-module-selection branch January 10, 2023 12:51
@yast-bot
Copy link

✔️ Internal Jenkins job #27 successfully finished
✔️ Created IBS submit request #287921

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants