Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AutoYaST: Handling variables in add-on URLs #28

Merged
merged 2 commits into from
Apr 7, 2017
Merged

AutoYaST: Handling variables in add-on URLs #28

merged 2 commits into from
Apr 7, 2017

Conversation

schubi2
Copy link
Member

@schubi2 schubi2 commented Apr 29, 2016 •
edited by mvidner

@lslezak
Copy link
Member

lslezak commented Apr 29, 2016

Um, unfortunately this is not the correct solution, it works, but the problem is that the final repository URL saved to /etc/zypp/repos.d/ has the variables expanded. That means the $releasever part is replaced by the current version. If you later upgrade the system the repo will still point to the old obsoleted repository. 😟

The linked example in bugzilla is a bit tricky. It scans the products with the expanded URL but when storing the repository it uses the original unexpanded URL (with $releasever).

Either we need to switch to the same approach (using different Pkg calls) or fix the Pkg.SourceCreate() function to handle URLs better. I'll look at the latter case as it should fix also the other cases...

@lslezak lslezak force-pushed the review_160429_releasever_tag branch from ffe8fae to a7596ba Compare April 3, 2017 11:22
@lslezak
Copy link
Member

lslezak commented Apr 3, 2017

I have improved the proposed patch

  • It expands the URL only for the repository creating step
  • The original URL is set back to have saved the correct entry in the /etc/zypp/repos.d file

@lslezak
Copy link
Member

lslezak commented Apr 3, 2017

Untested, @schubi2 could you test it?

@lslezak lslezak force-pushed the review_160429_releasever_tag branch from a7596ba to d9c9638 Compare April 3, 2017 11:47
@lslezak lslezak changed the title Handling in URLs AutoYaST: Handling variables in add-on URLs Apr 3, 2017
@lslezak lslezak mentioned this pull request Apr 7, 2017
Merged
@lslezak
Copy link
Member

lslezak commented Apr 7, 2017

JFYI: In SLES it requires additional patch yast/yast-packager#244

@schubi2
Copy link
Member Author

schubi2 commented Apr 7, 2017

LGTM

lslezak
lslezak approved these changes Apr 7, 2017
View reviewed changes
Copy link
Member

@lslezak lslezak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lslezak lslezak merged commit b7f8a29 into master Apr 7, 2017
@lslezak lslezak deleted the review_160429_releasever_tag branch April 7, 2017 14:40
dgdavid added a commit that referenced this pull request Jan 20, 2022
@dgdavid
Restores the unexpanded repo URL
af0ce6f 
See #28 (comment),
#54 (review),
and https://bugzilla.suse.com/show_bug.cgi?id=1194851
@dgdavid dgdavid mentioned this pull request Jan 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lslezak lslezak lslezak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@schubi2 @lslezak