-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run pre-scripts just after the profile has been processed #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Init script: Checking working network with network-online.target (#564) * Init script: Checking working network with network-online.target
Permit to use CDATA in the ntp_policy attribute
teclator
force-pushed
the
execute_prescripts_earlier
branch
from
July 3, 2020 15:39
2b6a8e4
to
615596f
Compare
teclator
force-pushed
the
execute_prescripts_earlier
branch
from
July 3, 2020 15:43
615596f
to
6353585
Compare
During tests we have found that askDialog is already broken in SLE-15-SP2 since: as the client does not include Yast::UIShortcuts. Before the move to a class it inherited from Yast::Client, so already included it. https://github.com/yast/yast-autoinstallation/pull/543/files#diff-c48716dab37675fe6b5e8c896f961ba0L13 |
Run pre-scripts just after the profile has been processed (SLE-15-GA)
Merge SLE-15-GA into SLE-15-SP1
teclator
force-pushed
the
execute_prescripts_earlier
branch
from
July 8, 2020 15:29
6353585
to
c6cc9e8
Compare
imobachgs
approved these changes
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
AutoYaST pre-scripts are expected to be run before any other configuration, but since the introduction of the unified installation medium them are run after a check of the selected product.
If the profile is modified by user pre-scripts providing the product name to be used, a error eport will be shown as there is no product defined in the profile.
Solution
Move the execution of the user pre-scripts as early as possible, that is, just after the profile has been processed.
This solution was already merged into SLE-15-GA and SLE-15-SP1 (#638 & #641) , so, this PR is a merge PR o that changes.
Test
Minimal fetch profile
fetch script