SLE12-SP1: initialize bootloader during update if proposed from scratch (bnc#899743)

[jsrain]

Don't merge anywhere before SP1 development

[jsrain]

See also yast/yast-packager#96

[coveralls]

Coverage remained the same when pulling 84aa509 on jsrain:bnc899743 into d1c8cfc on yast:master.

[jreidinger]

When I think about it, I worry that it will need more serious changes for SP1 as SLE12 code always re-propose configuration, which is now what we want for SP1

[jsrain]

Why do you think so? The re-proposal happens depending on bootloader type read from the system.

[jsrain]

Again checked the code, proposal client states:
if Mode.update
if ["grub2", "grub2-efi"].include? old_bootloader
Builtins.y2milestone "update of grub2, do not repropose"
if !BootCommon.was_read || @force_reset
# blRead(reread, avoid_reading_device_map)
Bootloader.blRead(true, true)
BootCommon.was_read = true
end
else
if !BootCommon.was_proposed || @force_reset
# Repropose the type. A regular Reset/Propose is not enough.
# For more details see bnc#872081
BootCommon.setLoaderType(nil)
Bootloader.Reset
Bootloader.Propose
end
end
else
# in installation always propose missing stuff
Bootloader.Propose
end
This means that we should be set even for SP1 - if old bootloader is GRUB2, it will be updated, otherwise configuration proposed from scratch.
Please, tell me if you have further comments, otherwise I will make it merge-able.

[jreidinger]

I think we need at least add "none" bootloader, as for it we do not want to overwrite user configuration if he really do not want to automanage dependencies. Otherwise it should work.

[jsrain]

Good point :-)

[jreidinger]

otherwise it looks good.

[jreidinger]

Looks good, just please also update brand new testsuite to cover this new "none" case https://github.com/yast/yast-bootloader/blob/master/test/bootloader_proposal_client_test.rb#L144

[coveralls]

Coverage remained the same at 58.9% when pulling 718246d on jsrain:bnc899743 into 9e52242 on yast:master.

[coveralls]

Coverage decreased (-0.02%) to 58.88% when pulling 718246d on jsrain:bnc899743 into 9e52242 on yast:master.

[coveralls]

Coverage increased (+0.08%) to 58.97% when pulling a3d5c6d on jsrain:bnc899743 into 9e52242 on yast:master.

[jreidinger]

good code coverage increased. Just last fail in travis from rubocop:

14.98s$ rubocop

warning: parser/current is loading parser/ruby21, which recognizes

warning: 2.1.5-compliant syntax, but you are running 2.1.2.

Inspecting 66 files

....................................C.............................

Offenses:

src/clients/inst_bootloader.rb:35:31: C: Do not leave space between ! and its argument.

if Mode.installation || ! BootCommon.was_read

[jreidinger]

you are quick. LGTM if travis passed

[jsrain]

Just wanted to write that I was faster :-)

[coveralls]

Coverage increased (+0.08%) to 58.97% when pulling 87952b5 on jsrain:bnc899743 into 9e52242 on yast:master.