-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SLE12-SP1: initialize bootloader during update if proposed from scratch (bnc#899743) #201
Conversation
See also yast/yast-packager#96 |
When I think about it, I worry that it will need more serious changes for SP1 as SLE12 code always re-propose configuration, which is now what we want for SP1 |
Why do you think so? The re-proposal happens depending on bootloader type read from the system. |
Again checked the code, proposal client states: |
I think we need at least add "none" bootloader, as for it we do not want to overwrite user configuration if he really do not want to automanage dependencies. Otherwise it should work. |
Good point :-) |
otherwise it looks good. |
Conflicts: package/yast2-bootloader.changes src/clients/bootloader_proposal.rb
Looks good, just please also update brand new testsuite to cover this new "none" case https://github.com/yast/yast-bootloader/blob/master/test/bootloader_proposal_client_test.rb#L144 |
good code coverage increased. Just last fail in travis from rubocop: 14.98s$ rubocop warning: parser/current is loading parser/ruby21, which recognizes warning: 2.1.5-compliant syntax, but you are running 2.1.2. Inspecting 66 files ....................................C............................. Offenses: src/clients/inst_bootloader.rb:35:31: C: Do not leave space between ! and its argument. if Mode.installation || ! BootCommon.was_read |
you are quick. LGTM if travis passed |
Just wanted to write that I was faster :-) |
SLE12-SP1: initialize bootloader during update if proposed from scratch (bnc#899743)
Don't merge anywhere before SP1 development