Grub1 crash #236
Grub1 crash #236
Conversation
| @@ -128,7 +128,7 @@ def MainDialog | |||
|
|
|||
| ) | |||
| if ret != :back && ret != :abort && ret != :cancel | |||
| @return_tab = CWMTab.LastTab | |||
| @return_tab = CWMTab.LastTab || "tab" | |||
There was a problem hiding this comment.
So "tab" is both the id of an existing Tab widget, and a fake name of a non-existing tab?
There was a problem hiding this comment.
Yes, it is a bit tricky. In grub2 due to different design it do not exists, so it is replaced by installation tab. So I use it here as default value.
There was a problem hiding this comment.
So, could we use "fake_tab" here...
There was a problem hiding this comment.
no as fake_tab do not exist, it should be existing id value
| @@ -128,7 +128,7 @@ def MainDialog | |||
|
|
|||
| ) | |||
| if ret != :back && ret != :abort && ret != :cancel | |||
| @return_tab = CWMTab.LastTab | |||
| @return_tab = CWMTab.LastTab || "tab" | |||
| @return_tab = "installation" if @return_tab.include? "tab" # workaround different tab set for grub2 | |||
There was a problem hiding this comment.
no as tab is proposed as initial tag elsewhere in code. So different part of code propose as default return_tab "tab" and here it is changed to grub2 default return tab..it is just relict of old multi-bootloader code that have here condition if bootloader == "grub2" && which is now useless. It deserve more cleaning but it is not part of this pr and I hope it will be cleaned together with perl-bootloader support drop off
|
LGTMed on IRC |
|
Changes Unknown when pulling 1cb3ce0 on grub1_crash into * on master*. |
|
Changes Unknown when pulling dd59501 on grub1_crash into * on master*. |
No description provided.