-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grub1 crash #236
Grub1 crash #236
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -128,7 +128,7 @@ def MainDialog | |
|
||
) | ||
if ret != :back && ret != :abort && ret != :cancel | ||
@return_tab = CWMTab.LastTab | ||
@return_tab = CWMTab.LastTab || "tab" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So "tab" is both the id of an existing Tab widget, and a fake name of a non-existing tab? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, it is a bit tricky. In grub2 due to different design it do not exists, so it is replaced by installation tab. So I use it here as default value. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So, could we use "fake_tab" here... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no as |
||
@return_tab = "installation" if @return_tab.include? "tab" # workaround different tab set for grub2 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. and "_tab" here? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no as tab is proposed as initial tag elsewhere in code. So different part of code propose as default return_tab "tab" and here it is changed to grub2 default return tab..it is just relict of old multi-bootloader code that have here condition if |
||
end | ||
ret | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is too implementation oriented. What are the user visible circumstances? The bug title "Startup of YaST bootloader fails" is also too generic to be helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should for unsupported bootloader that it do not show red popup with crash :)