allow optional types for string and map #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvidner
reviewed
May 5, 2020
| @@ -2,28 +2,36 @@ default namespace = "http://www.suse.com/1.0/yast2ns" | |||
| namespace a = "http://relaxng.org/ns/compatibility/annotations/1.0" | |||
| namespace config = "http://www.suse.com/1.0/configns" | |||
|
|
|||
| STRING_BOOL = STRING_ATTR, ("true" | "false") | |||
There was a problem hiding this comment.
we should still
include "common.rnc"
even if we don't run the validation yet
There was a problem hiding this comment.
how it will behave in final build which include everything? will be common.rng included many times?
|
@mvidner - to your question, no dependency, as modules should not depend on autoyast ( you do not want it on running system ). Also new references is not needed for trang, so only in yast2-schema it is good to have it together. for BSC I created https://bugzilla.suse.com/show_bug.cgi?id=1170886 |
* master: Bump version Update changes file Set AutoInstClonable in the desktop file
imobachgs
approved these changes
May 7, 2020
|
✔️ Public Jenkins job #54 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trello: https://trello.com/c/HkFkUQHj/1791-3-continue-with-new-xml-parser-xml-validation
depends on yast/yast-autoinstallation#598
Agreed to postpone for now that trang and jing travis validation to not delay even more new xml parser.