-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adapt schema files #598
adapt schema files #598
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless I have overlooked something, it looks good to me.
PR description missing |
@@ -23,6 +31,9 @@ SYMBOL = | |||
LIST = | |||
attribute config:type { "list" } | |||
|
|||
MAP = | |||
attribute config:type { "map" }? | |||
|
|||
# this is useful for testing | |||
Anything = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW the *
aka <anyName/>
that this uses would crash REXML RelaxNG if used. But it does not implement include
either so it
a. won't crash
b. won't be able to use the AY schema
I will make a REXML issue/PR about this.
file_path = element file_path { STRING } | ||
file_permissions = element file_permissions { STRING } | ||
file_owner = element file_owner { STRING } | ||
file_script = element file_script { MAP, (interpreter & source? & element location { STRING }? ) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
multiple lines please
Also, interpreter
and source
are from scripts.rnc, we may want to clean up these dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, I do not do any reformatting just, fixes.
src/autoyast-rnc/partitioning.rnc
Outdated
|
||
subvolumes = element subvolumes { | ||
LIST, | ||
subvolume* | ||
} | ||
|
||
# by default, AutoYaST exports list entries as 'listentry' | ||
# TODO: it can be configured to export it as subvolume, maybe do it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is comment for that default export as listentry...We found on IRC that it is already fixed and we export it as subvolume already. I will remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, remove please
Co-authored-by: Martin Vidner <mvidner@suse.cz>
Co-authored-by: Martin Vidner <mvidner@suse.cz>
✔️ Public Jenkins job #73 successfully finished |
No description provided.