Updated Salt forms support #44

imobachgs · 2019-01-25T14:50:57Z

https://fate.suse.com/322722
https://trello.com/c/IYMAlIxm

This PR merges the support for the current Salt Formulas forms specification. It includes several PRs: #18, #19, #21, #22, #24, #25, #26, #28, #30, #32, #34, #35, #36, #37, #38, #39, #40, #41, #42 and #43.

Pending stuff:

Adapt widgets to the update_visibility API.
Adapt forms height
Fix form title
Implement itemName
Implement minItems/maxItems support
Implement required/optional
Represent scalar collections as an array of hashes. See this comment.
Address codeclimate issues.
Improve test coverage

Added class representing a Salt Formula Form

"name" is ambiguous, alias it as "label" and distinguish from "id"

because the #initialize argument list grew too long

New Salt formulas form implementation

implement $visibleIf

Bump version and update changes file

coveralls · 2019-01-25T14:54:32Z

Coverage decreased (-7.6%) to 87.843% when pulling b1f47bd on salt-forms-support-ng into 27c93ba on master.

Scalar collections fixes

mvidner

Wooohooo!

Copy form_data instead of calling to FormData.new

Don't call update_visibility on widgets that can't do it

Fix cancel

Minor fixes for 4.1.1

yast-bot · 2019-01-28T11:04:07Z

✔️ Public Jenkins job #6 successfully finished
✔️ Created OBS submit request #669035

yast-bot · 2019-01-28T11:09:17Z

✔️ Internal Jenkins job #7 successfully finished
✔️ Created IBS submit request #182860

teclator and others added 30 commits November 27, 2018 12:29

Added form class in the new namespace

8af9934

Fixed form initialization

c4b5bce

Added parent reference and some documentation

4cea5e4

Changes based on code review.

d63e653

Added the id instead of the name to the path

fefc59a

Check itself

78265a8

Make rubocop happy

1f63e5a

Apply changes based on code review.

62071a7

Merge pull request #19 from yast/salt-form-class

d029b84

Added class representing a Salt Formula Form

[RFC] New Salt formulas form support

3c78bcc

Open the dialog to add elements in an pop-up

5cfa446

Don't exit the whole thing when the popup is done

8f5c23d

Extract Select widget and add unit tests

9918c30

Extract the Text widget and add unit tests

4669de4

Extract Group widget and add unit tests

7ed0d21

Extract the Collection widget and add unit tests

cd9a124

Remove unneeded file

8125c78

Adapt FormBuilder to the new widgets layout

03678c5

Move the TestFormula client to the right place

bc77b1e

Fix Rubocop complains in FormController

849954b

Make Y2DIR additive

91165a1

Syntax fix

581dece

Add tests and fix FormBuilder documentation

4a5b3d8

Adapt FormController to FormBuilder API change

a04e28e

Update from code review

12e587d

Human readable labels in the forms; name -> id+label

0ce6633

"name" is ambiguous, alias it as "label" and distinguish from "id"

Let FormBuilder know all $type values

556062d

Merged Y2ConfigurationManagement::Widgets::*.from_spec into #initialize

e320505

because the #initialize argument list grew too long

Merge pull request #18 from yast/salt-form-poc

dec6b1d

New Salt formulas form implementation

Use the new form controller main dialog in the formula client

f194b10

teclator and others added 13 commits January 25, 2019 09:30

added key_value widget

5331746

Use a specific hash structure for scalar dictionaries

2aa96f7

Added key_value widget unit test

aa8c3da

Changes based on CR.

c2aaa93

Fix FormLocatorElement#unbounded to take strings into account

5de191f

Fix pillar values reading

2698e1a

Make rubocop happy

56396fd

Fix form.yml

d9caef9

Merge pull request #36 from yast/visible-if

5ca006e

implement $visibleIf

Bump version and update changes file

ab48731

Merge pull request #43 from yast/bump-version

6c4a330

Bump version and update changes file

Add a label for KeyValue widgets

03208dc

Fix KeyValue widget test

005a3e3

imobachgs changed the title ~~Salt forms support ng~~ Updated Salt forms support Jan 25, 2019

Merge pull request #42 from yast/key_value_widget

3afac9b

Scalar collections fixes

mvidner approved these changes Jan 25, 2019

View reviewed changes

imobachgs and others added 10 commits January 25, 2019 16:38

Copy form_data instead of calling to FormData.new

eaf8c9b

Merge pull request #46 from yast/adapt-update-visibility

82a1db5

Copy form_data instead of calling to FormData.new

Don't call update_visibility on widgets that can't do it

bd0c35c

Merge pull request #48 from yast/adapt-update-visibility

e5ccb57

Don't call update_visibility on widgets that can't do it

Return nil when the collection action is canceled.

3590f77

Do not show the help in form popup

21cdc76

Adapted unit test mocking the popup#run returned value

13c9762

Merge pull request #49 from yast/fix_cancel

f85f1bf

Fix cancel

Disable visibility updating

9c5c9ad

Merge pull request #50 from yast/prepare-4.1.1

b1f47bd

Minor fixes for 4.1.1

imobachgs merged commit 99b6092 into master Jan 28, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated Salt forms support #44

Updated Salt forms support #44

imobachgs commented Jan 25, 2019 •

edited

coveralls commented Jan 25, 2019 •

edited

mvidner left a comment

yast-bot commented Jan 28, 2019

yast-bot commented Jan 28, 2019

Updated Salt forms support #44

Updated Salt forms support #44

Conversation

imobachgs commented Jan 25, 2019 • edited

coveralls commented Jan 25, 2019 • edited

mvidner left a comment

Choose a reason for hiding this comment

yast-bot commented Jan 28, 2019

yast-bot commented Jan 28, 2019

imobachgs commented Jan 25, 2019 •

edited

coveralls commented Jan 25, 2019 •

edited