Salt form data #22

imobachgs · 2018-11-30T11:52:22Z

This PR adds support to store the data from the form so it can be exported later to be used as part of a Pillar.

Basically, a new FormData class has been added which offers an API to add, update and remove information (including collections). The data is referred using a regular path (eg. .root.person) and it is stored in a hash.

To avoid coupling the widgets with the form data, a new Form widget has been introduced. To populate the form with the initial values, the #value= method is used (values are then propagated to internal widgets). The #result method offers a way to get the final values.

In scope

Store the data from the forms.
Add and remove elements to/from a collection.

Out of scope

Editing existing elemens within a collection.
Exporting the data to a Pillar, although the test_formula client dumps the result to the standard output.

coveralls · 2018-11-30T12:06:35Z

Coverage increased (+0.4%) to 92.182% when pulling 81d1c51 on salt-form-data into c6b769e on salt-forms-support-ng.

src/lib/y2configuration_management/salt/form_data.rb

mvidner

Here's a first batch of comments before I run it and try to break it

src/lib/y2configuration_management/salt/form_builder.rb

src/lib/y2configuration_management/salt/form_controller.rb

mvidner · 2018-12-04T13:36:29Z

src/lib/y2configuration_management/widgets/form.rb

+      # This method propagates the values to the underlying widgets.
+      #
+      # @example Setting values for included widgets
+      #   form.values = { "name" => "John", "surname" => "Doe" }


Suggested change

# form.values = { "name" => "John", "surname" => "Doe" }

# form.value = { "name" => "John", "surname" => "Doe" }

src/lib/y2configuration_management/widgets/form.rb

mvidner · 2018-12-04T13:38:50Z

src/lib/y2configuration_management/widgets/group.rb

        VBox(*children)
      end
+
+      # Sets the value for the form


Hmm, this is copied from Form, I wonder if the code can be shared.

mvidner · 2018-12-04T13:48:33Z

src/lib/y2configuration_management/salt/form_controller.rb

+      #   version.
+      def next_handler
+        return false unless Yast::Popup.YesNo("Do you want to exit?")
+        puts data.to_h.inspect


Suggested change

puts data.to_h.inspect

require "yaml" # at the top of the file

puts data.to_h.to_yaml

mvidner · 2018-12-04T13:50:00Z

In the current state, when I change the Name field and press Next, the data still contains the old value.

src/lib/y2configuration_management/salt/form_controller.rb

* For debugging purposes only.

we should extract the common parts to a mixin

imobachgs force-pushed the salt-form-data branch from 5aba712 to a67591a Compare November 30, 2018 12:04

imobachgs force-pushed the salt-form-data branch from d3a67d8 to f24f262 Compare December 3, 2018 21:46

imobachgs changed the title ~~[WIP] Salt form data~~ Salt form data Dec 3, 2018