Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Europe/Kiev to Europe/Kyiv [SLE-15-SP6] #325

Merged
merged 4 commits into from
Jun 6, 2024

Conversation

shundhammer
Copy link
Contributor

@shundhammer shundhammer commented May 29, 2024

Target Branch

This is a merge of #324 to SLE-15-SP6. #326 is the merge of this to master / Factory / TW.

Problem

The Europe/Kiev timezone was renamed to Europe/Kyiv. See #324 for details.

Related PRs

@shundhammer
Copy link
Contributor Author

shundhammer commented Jun 4, 2024

One unit test is now failing: The one that checks our keyboard layouts against those in the system.

What the failing unit tests do is to compare the code field in yast-country/keyboard/src/lib/y2keyboard/keyboards.rb against the first field in /usr/share/systemd/kbd-model-map (package systemd).

Did that file change in SLE-15-SP6? Or is it simply missing in the container that we use in our CI?

Filed bsc#1225934 about this.

@coveralls
Copy link

Coverage Status

coverage: 42.991%. remained the same
when pulling 8c9b27d on huha-kyiv-15-6
into 9d62496 on SLE-15-SP6.

@coveralls
Copy link

Coverage Status

coverage: 42.991%. remained the same
when pulling 8c9b27d on huha-kyiv-15-6
into 9d62496 on SLE-15-SP6.

@lslezak
Copy link
Member

lslezak commented Jun 6, 2024

Fixed CI by installing the kbd package.

The package is quite big so it is installed only here and not in the shared container images because this is the only package which needs it.

The following 2 NEW packages are going to be installed:
  kbd kbd-legacy

2 new packages to install.
Overall download size: 2.3 MiB. Already cached: 0 B. After the operation, additional 4.5 MiB will be used.

@shundhammer shundhammer marked this pull request as ready for review June 6, 2024 08:14
@shundhammer shundhammer merged commit 8c09621 into SLE-15-SP6 Jun 6, 2024
10 checks passed
@shundhammer shundhammer deleted the huha-kyiv-15-6 branch June 6, 2024 08:18
@yast-bot
Copy link
Contributor

yast-bot commented Jun 6, 2024

❌ Internal Jenkins job #6 failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants