Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Europe/Kiev to Europe/Kyiv to align with timezone 2022b onwards #324

Merged
merged 1 commit into from
May 28, 2024

Conversation

Dzejrou
Copy link
Contributor

@Dzejrou Dzejrou commented May 28, 2024

Problem

In August 2022, the release of tz data/code of version 2022b renamed the Europe/Kiev timezone to Europe/Kyiv:

https://mm.icann.org/pipermail/tz-announce/2022-August/000071.html

This PR fixes the occurrences of the timezone name in yast-country.

This change has a caveat: With yast-translations not being updated, the new timezone label will not match any msgid and thus will not be translated. For example, I set my system to Czech localization and executed yast2 timezone, where I saw:

Turecko
Ukraine (Kyiv) <-- not translated
Ukrajina (Simferopol)

I'm planning to open also a PR for yast-translations that changes all msgid from 'Ukraine (Kiev)' to 'Ukraine (Kyiv)' with the msgstr being untouched (the translations are still the same) because the timezone 'Ukraine (Kiev)' no longer exists and that msgid (at least to my knowledge) has no other use.

@coveralls
Copy link

Coverage Status

coverage: 42.907%. remained the same
when pulling 5761750 on Dzejrou:kyiv-15sp5
into 8dc7782 on yast:SLE-15-SP5.

Copy link
Contributor

@shundhammer shundhammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thank you for the patch!

@shundhammer shundhammer merged commit c561760 into yast:SLE-15-SP5 May 28, 2024
5 checks passed
@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #755 successfully finished
✔️ Created IBS submit request #332522

@shundhammer
Copy link
Contributor

shundhammer commented May 29, 2024

PR to merge this to SLE-15-SP6: #325

@shundhammer
Copy link
Contributor

PR to merge this to master / Factory / TW: #326

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants