Update the Rubocop config #107
Conversation
to make it work with Rubocop 0.40.0
| # Do not check the module length, the YCP converted includes | ||
| # are usually too long. | ||
| Metrics/ModuleLength: | ||
| Enabled: false |
There was a problem hiding this comment.
this is wrong, we do not do it even for class length or method lenght...It is intentionally undefined, so if you generate rubocop config it adds current value and it try to check that it is not increased.
|
now it in general looks good, but I think that it deserve some discussion on mailing list about backward compatible ones, so we can decide which way we prefer and maybe we can force now recommended value? In general I think we should follow upstream guide unless we have good reason to change it. And backward compatibility in style guide is not good reason for me as it can be auto-corrected. |
|
OK, makes sense, initially I wanted to change the code as little as possible, but the argument about the upstream compatibility is really strong. I'll update it... |
| # Allow block.call: | ||
| # | ||
| # def foo(&block) | ||
| # var = block,call |
|
LGTM |
|
LGTM |
to make it work with Rubocop 0.40.0