Rubocop update #478
Merged
Rubocop update #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -856,7 +856,7 @@ def Run(widgets, functions, skip_store_for: []) | |||
|
|
|||
| next if ret.nil? | |||
|
|
|||
| ret = nil if !validateWidgets(widgets, event_descr) if save | |||
| ret = nil if save && (!validateWidgets(widgets, event_descr)) | |||
There was a problem hiding this comment.
👍 it was actually from my POV style bug of ruby conversion
|
reviewed till "Manually fixed Style/GuardClause" now need to look at L3 for a moment. |
Fortunately the default value is never used in the YaST code.
Ok, it's a bit cheating...
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preview for Rubocop update, let's see and discuss the changes.
Note: The commits
Manually fixed ...were fixed manually (and thus deserve extra careful review), the rest was fixed automatically Rubocop.See also yast/yast-devtools#107