add new shared rubocop config #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreidinger
commented
Jan 6, 2022
| - "**/*.spec" | ||
| TargetRubyVersion: 2.5 # 2.5 is the SLE15 version, so ensure that we use proper version | ||
| # By default enable all new cops | ||
| NewCops: enable |
There was a problem hiding this comment.
newly added. Basically default makes updating rubocop more iterative, but it does not fit to way how we update rubocop version.
jreidinger
commented
Jan 6, 2022
| Naming/VariableNumber: | ||
| # do not check numbers usage in symbols as it often come outside of ruby | ||
| # like `x86_64` | ||
| CheckSymbols: false |
jreidinger
commented
Jan 6, 2022
| # "#{path}element" | ||
| # so calls path.to_s and append element. Result is wrong path. | ||
| Style/StringConcatenation: | ||
| Enabled: false |
There was a problem hiding this comment.
new item, see explanation
jreidinger
commented
Jan 9, 2022
| # while there is agreement on reducing openstruct usage, | ||
| # it is still used too widely, so disable only per module when | ||
| # it is ready | ||
| Style/OpenStructUse: |
jreidinger
commented
Jan 9, 2022
|
|
||
| # Skip warning for constant definition in tests | ||
| # as in rspec we often locate testing data close to respective test | ||
| Lint/ConstantDefinitionInBlock: |
|
✔️ Public Jenkins job #30 successfully finished |
|
✔️ Internal Jenkins job #19 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes to previous config will be added as inline comment to this PR