Rpm version fix - revert using rpm for parsing
#44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2b8e26a. Reason: Use grep/sed instead of rpm, it prints the version string for each subpackage, more over it does some dependency evaluation and fails when not runnign in "C" locale. Simple grep/sed seems to be better...
- 3.1.11
|
LGTM |
lslezak
added a commit
that referenced
this pull request
Dec 11, 2013
Rpm version fix - revert using `rpm` for parsing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons:
grep/sedinstead ofrpm, it prints the version stringfor each subpackage
rpmdoes some dependency evaluation and fails when not runnign inClocale:Although running in
Clocale helps, it seems thatrpmdoes too much work and the simplegrepandsedseems to be a better approach...