Mode autoyast #127
Merged
Mode autoyast #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teclator
force-pushed
the
mode_autoyast
branch
from
e50e6aa
to
d359194
Compare
imobachgs
reviewed
Feb 27, 2020
teclator
force-pushed
the
mode_autoyast
branch
from
7152a2a
to
39fdeb1
Compare
teclator
commented
Feb 27, 2020
| @@ -399,4 +399,10 @@ | |||
| end | |||
| end | |||
| end | |||
|
|
|||
| describe "#packages" do | |||
There was a problem hiding this comment.
It was not related to the fix, but decreasing the test coverage is not nice 😆 . So, this was added just for increasing the test coverage slightly.
imobachgs
approved these changes
Feb 27, 2020
|
✔️ Public Jenkins job #29 successfully finished |
|
✔️ Internal Jenkins job #6 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In case of an autoinstallation with VNC, the server is not reachable during the second stage.
Solution
Bring back the firewall installation finish client which opens the VNC or SSH server ports if firewalld is installed and the installation is done remotely through VNC or SSH.
Test