Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mode autoyast #127

Merged
merged 6 commits into from
Feb 27, 2020
Merged

Mode autoyast #127

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7f1e860
Enable finish client for autoinstallation
teclator Feb 24, 2020
aefc5e7
Bump version & changelog
teclator Feb 26, 2020
d359194
Reduced configure_firewall method complexity
teclator Feb 26, 2020
f26a538
Changes based on code review.
teclator Feb 27, 2020
39fdeb1
Add a missing unit test
teclator Feb 27, 2020
ee18091
Use symbols instead of strings in all the receive method mocks
teclator Feb 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions test/lib/y2firewall/clients/auto_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,4 +399,10 @@
end
end
end

describe "#packages" do
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was not related to the fix, but decreasing the test coverage is not nice 😆 . So, this was added just for increasing the test coverage slightly.

it "returns a hash with firewalld as a package to be installed" do
expect(subject.packages).to eq("install" => ["firewalld"], "remove" => [])
end
end
end