Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Review] Request from 'schubi2' @ 'yast/yast-firewall/review_180504_stubbing_autoinstall_module' #64

Merged
merged 5 commits into from
May 4, 2018
Merged

[Review] Request from 'schubi2' @ 'yast/yast-firewall/review_180504_stubbing_autoinstall_module' #64

merged 5 commits into from
May 4, 2018

Conversation

schubi2
Copy link
Member

@schubi2 schubi2 commented May 4, 2018

Please review the following changes:

@coveralls
Copy link

coveralls commented May 4, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 82.54% when pulling d83535f on review_180504_stubbing_autoinstall_module into 14b8b5f on master.

lslezak
lslezak approved these changes May 4, 2018
View reviewed changes
Copy link
Member

@lslezak lslezak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schubi2 schubi2 merged commit de7ff5c into master May 4, 2018
@schubi2 schubi2 deleted the review_180504_stubbing_autoinstall_module branch May 4, 2018 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lslezak lslezak lslezak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@schubi2 @coveralls @lslezak @jreidinger