Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Improvements #117

Open
dgdavid opened this issue Jan 18, 2021 · 2 comments
Open

UI Improvements #117

dgdavid opened this issue Jan 18, 2021 · 2 comments
Labels
feedback Discussion or proposal (not a bug)

Comments

@dgdavid
Copy link
Member

dgdavid commented Jan 18, 2021

Context

Going through the example included in SLES (see #115)

Problems

  • Lack of paddings and margins (among other styles) in the steps column fixed, see UI Improvements #117 (comment)

    Click to show/hide outdated content

    Probably related to theming, as it only happens in SLE. In openSUSE it looks good, more polished.

    SLE openSUSE
    2_welcome firstboot_openSUSE
  • The sidebar for steps couldn't be shrink after going next

    This is a weird corner case, but if the user changes the space used by the left sidebar in the Language and keyboard layout step, it cannot be shrink later in next clients/dialogs.

  • The banner cannot be placed at the very top. Instead, it is placed at the top of right side

     <!-- Configuration of the installation/firstboot layout -->
     <installation_layout>
     	<mode>steps</mode>
     	<banner config:type="boolean">true</banner>
     </installation_layout>

    firstboot_first_step_with_banner

  • Some clients (for example, timezone) hide the steps

    Timezone client Registration client
    4_timezone 7_registration
  • Not unified abort message

    Aborting from language and keyboard client Aborting from Welcome client
    lang_and_keyboard welcome
    lang_and_keyboard_abort_message welcome_abort_message

Suggested solutions / Ideas

  • Give some love to the steps styles see UI Improvements #117 (comment)
  • Fix the resizable behavior of the left panel, if possible
  • Allow to put the banner at the very top, using the full width
  • Use the same abort message at any point.
  • Allow to customize the abort message, as is already possible with the welcome and finish messages.
@wfeldt
Copy link
Member

wfeldt commented Jan 20, 2021

The abort messages are mostly incorrect anyway as the notable difference compared to an installation is that each client applies its changes immediately when it's done compared to delaying all changes until after the summary screen.

It's not so much an 'abort' as rather a 'skip remaining steps'.

On a related note: the discussed clickable config-screen would (IMHO) do a better job here. But that's very much futuristic.

@ancorgs ancorgs added the feedback Discussion or proposal (not a bug) label Mar 16, 2021
@dgdavid
Copy link
Member Author

dgdavid commented Mar 29, 2021

  • Lack of paddings and margins (among other styles) in the steps column

    Probably related to theming, as it only happens in SLE. In openSUSE it looks good, more polished.

That has been fixed with changes in SLE theming. See yast/yast-theme@0f07143 and yast/yast-theme@58773f9

The steps looks much better now:

firstboot-new-theme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback Discussion or proposal (not a bug)
Projects
None yet
Development

No branches or pull requests

3 participants