Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt root and user clients to Y2User #123

Merged
merged 7 commits into from
Jun 28, 2021
Merged

Adapt root and user clients to Y2User #123

merged 7 commits into from
Jun 28, 2021

Conversation

dgdavid
Copy link
Member

@dgdavid dgdavid commented Jun 16, 2021 •
edited
Loading

Problem

yast2-users code is being adapted to use shadow tools. This module uses some API methods that are going to be dropped in favor of new Y2Users classes.

Solution

Adapt code to use the new Y2Users classes.

NOTE: this PR should not be merged yet. It requires yast-users/y2users branch to be merged before.

Test

  • Unit tests adapted
  • Manually tested

@dgdavid dgdavid added the WIP label Jun 16, 2021
@dgdavid dgdavid changed the title Adapt root and user clients to new Y2User objects Adapt root and user clients to Y2User Jun 17, 2021
@joseivanlopez joseivanlopez mentioned this pull request Jun 18, 2021
Merged
@dgdavid dgdavid marked this pull request as ready for review June 21, 2021 09:18
joseivanlopez
joseivanlopez approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@joseivanlopez joseivanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only minor details.

src/lib/y2firstboot/clients/root.rb Outdated Show resolved Hide resolved
src/lib/y2firstboot/clients/user.rb Outdated Show resolved Hide resolved
test/y2firstboot/clients/user_test.rb Outdated Show resolved Hide resolved
test/y2firstboot/clients/user_test.rb Show resolved Hide resolved
@dgdavid dgdavid removed the WIP label Jun 21, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 956807824

  • 37 of 39 (94.87%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.6%) to 13.027%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/y2firstboot/clients/user.rb 20 22 90.91%
Totals Coverage Status
Change from base Build 945941968: 3.6%
Covered Lines: 167
Relevant Lines: 1282
💛 - Coveralls

@ancorgs ancorgs mentioned this pull request Jun 28, 2021
Merged
ancorgs
ancorgs approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@ancorgs ancorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgdavid dgdavid merged commit eb4ebf5 into master Jun 28, 2021
@dgdavid dgdavid deleted the y2users branch June 28, 2021 11:54
@yast-bot
Copy link
Contributor

✔️ Public Jenkins job #48 successfully finished
✔️ Created OBS submit request #902807

@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #31 successfully finished
✔️ Created IBS submit request #243914

@dgdavid dgdavid mentioned this pull request Aug 26, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joseivanlopez joseivanlopez joseivanlopez approved these changes

@ancorgs ancorgs ancorgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dgdavid @coveralls @yast-bot @joseivanlopez @ancorgs