Unify (repeated) licenses clients

[dgdavid]

Problem

There are three clients/modules practically identical.

Related to

• PRs firstboot fixes #63, [Backport] Fix the example file #66
• bsc #1131327, #1131301

Solution

Keep only one (firstboot_licenses.rb).

How?

Just converting the rest of them (firstboot_license.rb and firstboot_license_novell.rb) to symbolic links to ensure the backward compatibility.

Besides, to avoid showing the default license when only the selected one is desired, it is necessary to not take care about the default license directory since this is already being done in the InstLicense client.

So, from now on, the firstboot.xml workflow only needs to include "firstboot_licenses" module

<module>
  <label>License Agreement</label>
  <enabled config:type="boolean">true</enabled>
  <name>firstboot_licenses</name>
</module>

Although using "firstboot_license" or "firstboot_novell_license" will produce the same results.

Test

• Added a basic unit test
• Tested manually

Screenshots

Let's see how the License agreement looks for each different scenarios. Click on each section to expand or collapse it.

Using the default values

---

That's, FIRSTBOOT_LICENSE_DIR and FIRSTBOOT_LICENSE_NOVELL_DIR are empty ("") or commented in /etc/sysconfig/firstboot.

The license texts found in the default directory (global param) will be displayed.

Using a valid path for FIRSTBOOT_LICENSE_DIR

---

Using a valid path for FIRSTBOOT_LICENSE_NOVELL_DIR

---

Using a valid path for both, FIRSTBOOT_LICENSE_DIR and FIRSTBOOT_LICENSE_NOVELL_DIR

---

---

NOTE: if any license file could not be found, the client simply will be skipped.