Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use deprecated Progress.on #79

Merged
merged 4 commits into from
Jan 16, 2020
Merged

Don't use deprecated Progress.on #79

merged 4 commits into from
Jan 16, 2020

Conversation

lnussel
Copy link
Contributor

@lnussel lnussel commented Oct 17, 2019

No description provided.

Copy link
Member

@jreidinger jreidinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for me. Please add changelog entry and increase version. Thanks

WSL doesn't have keyboard settings and after the refactoring of the
country module this call would fail as systemd is not running.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 329

  • 0 of 5 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 3.137%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/clients/firstboot.rb 0 2 0.0%
src/clients/firstboot_write.rb 0 3 0.0%
Totals Coverage Status
Change from base Build 328: -0.004%
Covered Lines: 75
Relevant Lines: 2391

💛 - Coveralls

@jreidinger jreidinger merged commit 19c42e0 into yast:master Jan 16, 2020
@yast-bot
Copy link
Contributor

✔️ Public Jenkins job #23 successfully finished
✔️ Created OBS submit request #764913

@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #10 successfully finished

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants