-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
travis build, bug fixes #10
Conversation
hmm, installation in travis now cause segfault, any idea why? https://travis-ci.org/yast/yast-fonts/builds/42187657 |
On Wed, Nov 26, 2014 at 04:11:49AM -0800, Josef Reidinger wrote:
Sure :). |
travis still said that it failing ;) |
On Thu, Nov 27, 2014 at 09:47:39AM -0800, Josef Reidinger wrote:
Yes, and it will be after last commit too, dunno why so far. |
You hou! |
…ig dialog is run to not confuse FcMatch()
…compatibility_symlink, metric_compatibility_bw_symlink
@@ -5,7 +5,8 @@ before_install: | |||
# disable rvm, use system Ruby | |||
- rvm reset | |||
- wget https://raw.githubusercontent.com/yast/yast-devtools/master/travis-tools/travis_setup.sh | |||
- sh ./travis_setup.sh -p "yast2 ruby2.1-dev" -g "rake yast-rake yard rspec:2.14.1" | |||
- sh ./travis_setup.sh -p "yast2 ruby2.1-dev libfont-specimen-dev fonts-liberation" -g "rake yast-rake yard rspec:2.14.1" | |||
- sudo apt-get -o Dpkg::Options::="--force-overwrite" install libfontconfig-new1-dev libfontconfig-new1 fontconfig-new-config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, add a comment why --force-overwrite
option is need, this is quite unusual...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On Thu, Dec 18, 2014 at 10:40:40AM -0800, Ladislav Slezák wrote:
Please, add a comment why --force-overwrite option is need, this is quite
unusual...
Ok, done.
All suggestions implemented. |
@fcstate.lcd_filter) | ||
UI.ChangeWidget(Id("cmb_specimen_subpixellayout"), :Value, | ||
@fcstate.subpixel_layout) | ||
if (!UI.TextMode) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it deserve comment why only in non text mode are these widgets modified.
In general it looks good, just fre small notes. |
@jreidinger, your suggestions were implemented. |
LGTM |
Thanks for review! |
No description provided.