Adapt to use new service widget #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imobachgs
reviewed
Aug 8, 2018
dgdavid
reviewed
Aug 8, 2018
src/modules/FtpServer.rb
Outdated
| # for backward compatibility, see {#write_daemon}. When the service | ||
| # is configured by using the UI, it directly saves the service, see | ||
| # {Yast2::SystemService#save}. | ||
| def save_status |
There was a problem hiding this comment.
In the http-sever I used save_service for an identical method. What do you about use the same naming, when possible, for the "service widget adaptation"?
I don't mind to change save_service to save_status if you think it is more accurate :)
There was a problem hiding this comment.
Well, in this case I named it #save_status because it saves the service status in different ways depending on the mode. It does not always "save the service", understanding "service" is our SystemService.
dgdavid
approved these changes
Aug 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of PBI https://trello.com/c/uAe4i9Ru/107-5-fate319428-allow-socket-activation-widget