Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardening #54

Merged
merged 3 commits into from
Dec 5, 2018
Merged

Hardening #54

merged 3 commits into from
Dec 5, 2018

Conversation

jreidinger
Copy link
Member

No description provided.

"; fi"
)
# "dir=`ls /srv/ftp/ | grep upload`; if [ -z $dir ]; then echo $dir; mkdir /srv/ftp/upload;
# chown ftp:ftp /srv/ftp/upload/; chmod 755 /srv/ftp/upload; else chmod 766 /srv/ftp/upload/; fi"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is old script encoded in Ops.add.

Copy link
Contributor

@joseivanlopez joseivanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much more understandable now. Only fix rubocop.

Copy link
Contributor

@joseivanlopez joseivanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I overlooked the typo with octal literals.

@jreidinger jreidinger merged commit 04f7376 into master Dec 5, 2018
@jreidinger jreidinger deleted the hardening branch December 5, 2018 12:53
@yast-bot
Copy link
Contributor

yast-bot commented Dec 5, 2018

✔️ Public Jenkins job #8 successfully finished
✔️ Created OBS submit request #655337

@yast-bot
Copy link
Contributor

yast-bot commented Dec 5, 2018

✔️ Internal Jenkins job #8 successfully finished
✔️ Created IBS submit request #179194

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 3.58% when pulling fe5e530 on hardening into edcb776 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants