Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback to ::FileUtils those Yast::FileUtils missing methods #997

Closed
wants to merge 1 commit into from
Closed

Fallback to ::FileUtils those Yast::FileUtils missing methods #997

wants to merge 1 commit into from

Conversation

dgdavid
Copy link
Member

@dgdavid dgdavid commented Dec 5, 2019 •
edited
Loading

⚠️ Discarded, see the reason below

Problem

Sometimes Yast::FileUtils is taking the place of ::FileUtils

See also,

Solution

Send the missing Yast::FileUtils methods to ::FileUtils (and log the action)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0008%) to 29.967% when pulling 524c380 on fix_fileutils into 6bc7bd9 on master.

@dgdavid
Copy link
Member Author

dgdavid commented Dec 12, 2019

According to the feedback given in https://lists.opensuse.org/yast-devel/2019-12/msg00003.html, we're going to use the scope resolution operator :: whenever is needed instead.

@dgdavid dgdavid closed this Dec 12, 2019
@teclator teclator mentioned this pull request Apr 14, 2020
Merged
@dgdavid dgdavid deleted the fix_fileutils branch March 3, 2021 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dgdavid @coveralls