Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests #60

Merged
merged 1 commit into from
Jul 19, 2019
Merged

Fix tests #60

merged 1 commit into from
Jul 19, 2019

Conversation

joseivanlopez
Copy link
Contributor

@joseivanlopez joseivanlopez commented Jul 19, 2019 •
edited
Loading

Problem

Tests in #57 are failing when it tries to import Users module.

See https://build.suse.de/request/show/197134

Solution

Stubbing unnecessary module importation for tests.

@joseivanlopez joseivanlopez changed the base branch from master to SLE-15-SP1 July 19, 2019 15:31
@coveralls
Copy link

Coverage Status

Coverage remained the same at 23.47% when pulling b2979ae on joseivanlopez:fix_test2 into 018d903 on yast:SLE-15-SP1.

@joseivanlopez joseivanlopez merged commit c5f2e82 into yast:SLE-15-SP1 Jul 19, 2019
@joseivanlopez joseivanlopez mentioned this pull request Jul 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreidinger jreidinger jreidinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joseivanlopez @coveralls @jreidinger