Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix show command #57

Merged
merged 5 commits into from
Jul 19, 2019
Merged

Fix show command #57

merged 5 commits into from
Jul 19, 2019

Conversation

joseivanlopez
Copy link
Contributor

@joseivanlopez joseivanlopez commented Jul 19, 2019

Problem

Show command does not show the correct value of the allowed user option.

Solution

Show command was fixed to show correct value.

Clients have been moved to lib. Testing was almost impossible with old clients where the client is run in the last line of the file.

Testing

  • Added unit tests
  • Manually tested

Copy link
Member

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joseivanlopez joseivanlopez force-pushed the fix_show branch 2 times, most recently from d26b568 to 6dc6b1c Compare July 19, 2019 13:40
Copy link
Member

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, looks better than before :)

So, still looking good to me 👍 Thanks for taking care.

@joseivanlopez joseivanlopez merged commit 892132a into yast:SLE-15-SP1 Jul 19, 2019
This was referenced Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants